FIX: PlayerInput default ActionMap set to <None> is overwritten#2170
Merged
FIX: PlayerInput default ActionMap set to <None> is overwritten#2170
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
Did you try that with the latest commit? I changed it so it should default to the first action map initially |
Collaborator
Nope I was one commit off, ignore that |
Pauliusd01
approved these changes
Apr 23, 2025
Collaborator
Pauliusd01
left a comment
There was a problem hiding this comment.
LGTM, tried checking the debugger when toggling between none and different maps and ran through existing player input sample scenes to make sure they are still working the same way
jfreire-unity
approved these changes
Apr 23, 2025
Collaborator
jfreire-unity
left a comment
There was a problem hiding this comment.
Nice! Thanks for fixing it for the forum user 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default was overwritten for the defaultActionMap everyTime the Asset is changed.
Testing status & QA
Manually tested, further testing needed.
Overall Product Risks
Comments to reviewers
There is no ticket yet, I quick fixed this from this forum post and slack thread:
https://unity.slack.com/archives/C09Q7LYP9/p1745346184316539
https://discussions.unity.com/t/unity-player-input-default-map-can-not-be-empty-input-system-1-14-0/1630448
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: