Skip to content

FIX: PlayerInput default ActionMap set to <None> is overwritten#2170

Merged
ritamerkl merged 4 commits intodevelopfrom
fix-playerinput-overwriting-default-actionmap
Apr 24, 2025
Merged

FIX: PlayerInput default ActionMap set to <None> is overwritten#2170
ritamerkl merged 4 commits intodevelopfrom
fix-playerinput-overwriting-default-actionmap

Conversation

@ritamerkl
Copy link
Copy Markdown
Collaborator

@ritamerkl ritamerkl commented Apr 23, 2025

Description

The default was overwritten for the defaultActionMap everyTime the Asset is changed.

Testing status & QA

Manually tested, further testing needed.

Overall Product Risks

  • Complexity: low
  • Halo Effect: medium

Comments to reviewers

There is no ticket yet, I quick fixed this from this forum post and slack thread:
https://unity.slack.com/archives/C09Q7LYP9/p1745346184316539
https://discussions.unity.com/t/unity-player-input-default-map-can-not-be-empty-input-system-1-14-0/1630448

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Pauliusd01

This comment was marked as resolved.

@ritamerkl
Copy link
Copy Markdown
Collaborator Author

ritamerkl commented Apr 23, 2025

This changes the default choice from the first map to none which might be undesirable?

Did you try that with the latest commit? I changed it so it should default to the first action map initially

@Pauliusd01
Copy link
Copy Markdown
Collaborator

This changes the default choice from the first map to none which might be undesirable?

Did you try that with the latest commit? I changed it so it should default to the first action map initially

Nope I was one commit off, ignore that

Copy link
Copy Markdown
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tried checking the debugger when toggling between none and different maps and ran through existing player input sample scenes to make sure they are still working the same way

Copy link
Copy Markdown
Collaborator

@jfreire-unity jfreire-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing it for the forum user 💪

@ritamerkl ritamerkl merged commit e77f650 into develop Apr 24, 2025
110 checks passed
@ritamerkl ritamerkl deleted the fix-playerinput-overwriting-default-actionmap branch April 24, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants